feat: Add InternalIPs to CreateMachineResponse#140
Conversation
ske-prow
bot
added
do-not-merge/hold
jamand
force-pushed
the
feat/add-machine-internal-ip-status-field
branch
from
0a4a0d5 to
2e0be67
Compare
jamand
force-pushed
the
feat/add-machine-internal-ip-status-field
branch
from
8439761 to
8f95f5f
Compare
Co-authored-by: Felix Breuer <f.breuer94@gmail.com>
jamand
force-pushed
the
feat/add-machine-internal-ip-status-field
branch
from
8f95f5f to
d39fd9f
Compare
|
@breuerfelix Thanks! I also ran a test in an ondemand environment testing the self-hosted shoot scenario using gardenadm (only in this case the IP is written into the |
|
/unhold |
ske-prow
bot
removed
the
do-not-merge/hold
breuerfelix
left a comment
breuerfelix
left a comment
There was a problem hiding this comment.
also tested in ondemand that normal shoot creation still works
|
LGTM label has been added. DetailsGit tree hash: 030959259b40456a1ced2557355b83e95fdd184f |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breuerfelix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
2 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Similar to gardener/machine-controller-manager-provider-openstack#322
Server InternalIPs are now returned on created Machines, so that they may be used for access. This is needed, as the provided hostname field already written into is the
MachineStatus.Addressesis not resolvable on STACKIT.Which issue(s) this PR fixes:
x
Special notes for your reviewer:
The
clientSuite was previously not registered and there was a small bug in one test case./hold Running tests first